-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add TS type declaration and pkg.json types entry #164
Conversation
Ah, thanks! I'm just now noticing that we didn't deprecate the callback function like we were going to - there isn't any async behavior anymore. |
Let me know if you want it documented differently, or if you update the API and would rather have me update the typings. |
I'm not familiar with typescript, but is there any reason to not follow hapijs' style guidelines in regards to semicolon usage and indentation? |
I didn't catch that, sorry! I'll see about getting my formatter to cooperate. Do you guys have an |
I'll update the API and docs - can you update the ts definition to remove the optional callback? (I'm not at my computer right now but will be shortly) |
I just scanned the style guide briefly. Basically just switched to using spaces and semis. Also removed the callback param. |
Joi appears to be the only project that includes a .editorconfig. We use lab to validate adherence to our style guide. See also outmoded/hapi-contrib#38. |
Merged, thanks! |
Awesome! Do you have a set release cycle? When might this make it onto npm so I can remove my own typings? |
I'll go update the docs when I'm at my computer and release that together as |
Cheers! Thank you! |
@skeggse It's not going to be enough, .npmignore will drop it on publish. |
Doesn't |
Released in |
My bad, all other hapi projects put it at the root, reflex :p |
True! I just followed what you guys had going. Didn't even realize I saved myself that faux pas! |
Convenience for TypeScript and vscode users.